Enable a different announcement for premium releases #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft until I've been able to test it |
The basic data of what is considered premium and what is considered public releases, a new bash function is added, std_release_type(), found in release-tools/release-aux/release-data-fn.sh. Along with this, the non-descript variable 'tag' is renamed to 'release_tag', and a spelling error is corrected. Fixes openssl#157
|
Tested, so ready for review |
alich0
reviewed
Jun 23, 2023
| release_text="$release" | ||
| announce_template=openssl-announce-release.tmpl | ||
| announce_template=openssl-announce-release-$release_type.tmpl |
There was a problem hiding this comment.
I haven't tracked down if possible to give wrong $VERSION. If yes, this would result in:
"announce_template=openssl-announce-release-.tmpl" since "std_release_type" function returns empty string if doesn't meet the regular expression criteria (to return "premium" or "public".
mattcaswell
approved these changes
Jun 23, 2023
t8m
approved these changes
Jun 23, 2023
|
Merged. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 23, 2023
The basic data of what is considered premium and what is considered public releases, a new bash function is added, std_release_type(), found in release-tools/release-aux/release-data-fn.sh. Along with this, the non-descript variable 'tag' is renamed to 'release_tag', and a spelling error is corrected. Fixes #157 Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from #160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic data of what is considered premium and what is considered
public releases, a new bash function is added, std_release_type(), found in
release-tools/release-aux/release-data-fn.sh.
Along with this, the non-descript variable 'tag' is renamed to 'release_tag',
and a spelling error is corrected.
Fixes #157